Skip to content

Fixes URL parsing on Windows#5

Merged
pabloderen merged 1 commit intomainfrom
hotfix/OddScapeCharIn3LeggedToken
Feb 24, 2026
Merged

Fixes URL parsing on Windows#5
pabloderen merged 1 commit intomainfrom
hotfix/OddScapeCharIn3LeggedToken

Conversation

@pabloderen
Copy link
Collaborator

@pabloderen pabloderen commented Feb 23, 2026 •
edited by coderabbitai bot
Loading

Addresses an issue where the cmd.exe command interpreter on Windows
incorrectly parses URLs containing ampersands ('&') when opening them in
the browser.

Replaces the cmd command with powershell to properly handle URLs
passed to Start-Process.

Summary by CodeRabbit

  • Bug Fixes
    • Improved URL handling on Windows to correctly open browser links, especially those containing special characters like ampersands.

@pderendinger-everse
Fixes URL parsing on Windows
872ea80 
Addresses an issue where the `cmd.exe` command interpreter on Windows
incorrectly parses URLs containing ampersands ('&') when opening them in
the browser.

Replaces the `cmd` command with `powershell` to properly handle URLs
passed to `Start-Process`.
@coderabbitai
Copy link

coderabbitai bot commented Feb 23, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7081462 and 872ea80.

📒 Files selected for processing (1)
  • src/aps-auth.ts

Walkthrough

Updates the Windows browser launching mechanism in the authentication module from cmd /c start to PowerShell's Start-Process with non-interactive flags to prevent ampersand interpretation issues in URLs, while maintaining the existing macOS and Linux implementations.

Changes

Cohort / File(s) Summary
Windows Browser Launch Mechanism
src/aps-auth.ts		 Replaces cmd /c start invocation with PowerShell Start-Process command using non-interactive flags to properly handle URLs containing ampersands without special character interpretation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A rabbit hops through digital halls,
Where ampersands once caused browser calls to stall,
PowerShell whispers, "Take this route,"
URLs safe, no more dispute!
Windows opens wide, finally smooth & right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'Fixes URL parsing on Windows' directly relates to the main change—replacing Windows URL opening mechanism from cmd to PowerShell to properly handle ampersands in URLs.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hotfix/OddScapeCharIn3LeggedToken

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pabloderen pabloderen merged commit 727868c into main Feb 24, 2026
2 checks passed
@pabloderen pabloderen deleted the hotfix/OddScapeCharIn3LeggedToken branch February 24, 2026 19:51
@github-actions
Copy link

github-actions bot commented Feb 24, 2026

🎉 This PR is included in version 1.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pabloderen @pderendinger-everse